Queen attack#970
Conversation
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
mk-mxp
added
x:action/sync
| ]); | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
All changes to this file should not be in this pull request. Please update your fork to the current version of main and rebase your git branch. That should revert changes to this file.
There was a problem hiding this comment.
Oh wow, sorry about this, thank you
|
|
||
| /** | ||
| * Test a queen is placed in a valid position. | ||
| /** |
There was a problem hiding this comment.
Please be more accurate with formatting. I had to correct plenty of whitespace issues like this in the previous PR. Haste does not safe anyone anything.
| /** | |
| /** |
There was a problem hiding this comment.
Okay, though I formatted, sorry about that
There was a problem hiding this comment.
This seems to have come back again...
There was a problem hiding this comment.
Please remove the tests on exception messages from all tests:
A-O-Emmanuel
force-pushed
the
queen-attack
branch
from
eb85ba4 to
50a9dca
Compare
mk-mxp
left a comment
mk-mxp
left a comment
There was a problem hiding this comment.
Thanks for investing so much time and effort! Only 2 little whitespace issues left before merging.
|
|
||
| /** | ||
| * Test a queen is placed in a valid position. | ||
| /** |
There was a problem hiding this comment.
This seems to have come back again...
| } | ||
|
|
||
| /** | ||
| * uuid: 543f8fd4-2597-4aad-8d77-cbdab63619f8 |
There was a problem hiding this comment.
And here a space is missing:
| * uuid: 543f8fd4-2597-4aad-8d77-cbdab63619f8 | |
| * uuid: 543f8fd4-2597-4aad-8d77-cbdab63619f8 |
mk-mxp
added
x:size/small
2 participants
This pull request does the following:
Sync test files and meta data to problem specification
Drop strict types comments from test file and example code
Add and sync test meta data to tests (uuid in DocBlocks / #TestDox())
Add exercise to bin/auto-sync.txt to keep it in sync (keep the file alphabetically sorted)
Adding / adjust / ordering test cases to match current problem specs
Add missing test case