Skip to content

Commit 362b638

Browse files
dyc3autofix-ci[bot]ematipicocoderabbitai[bot]
authored
fix(migrate): update some more rule metadata (#9888)
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Emanuele Stoppa <my.burning@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
1 parent a2933bf commit 362b638

4 files changed

Lines changed: 30 additions & 6 deletions

File tree

.changeset/many-snakes-wonder.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@biomejs/biome": patch
3+
---
4+
5+
Updated metadata for `biome migrate eslint` to better reflect which ESLint rules are redundant versus unsupported versus unimplemented.

crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs

Lines changed: 16 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

crates/biome_cli/src/execute/migrate/unsupported_rules.rs

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -272,8 +272,8 @@ pub const UNSUPPORTED_RULES: &[UnsupportedRule] = &[
272272
UnsupportedRule(EslintVueJs("arrow-spacing"), Stylistic),
273273
UnsupportedRule(EslintVueJs("block-spacing"), FormatterCovers),
274274
UnsupportedRule(EslintVueJs("block-tag-newline"), Stylistic),
275-
UnsupportedRule(EslintVueJs("brace-style"), Stylistic),
276-
UnsupportedRule(EslintVueJs("comma-dangle"), Stylistic),
275+
UnsupportedRule(EslintVueJs("brace-style"), FormatterCovers),
276+
UnsupportedRule(EslintVueJs("comma-dangle"), FormatterCovers),
277277
UnsupportedRule(EslintVueJs("comma-spacing"), FormatterCovers),
278278
UnsupportedRule(EslintVueJs("comma-style"), Stylistic),
279279
UnsupportedRule(EslintVueJs("dot-location"), Stylistic),
@@ -292,14 +292,17 @@ pub const UNSUPPORTED_RULES: &[UnsupportedRule] = &[
292292
),
293293
UnsupportedRule(EslintVueJs("key-spacing"), FormatterCovers),
294294
UnsupportedRule(EslintVueJs("keyword-spacing"), FormatterCovers),
295-
UnsupportedRule(EslintVueJs("max-attributes-per-line"), FormatterCovers),
295+
UnsupportedRule(EslintVueJs("max-attributes-per-line"), Stylistic),
296296
UnsupportedRule(EslintVueJs("max-len"), FormatterOption("lineWidth")),
297297
UnsupportedRule(
298298
EslintVueJs("multiline-html-element-content-newline"),
299-
Stylistic,
299+
FormatterCovers,
300300
),
301301
UnsupportedRule(EslintVueJs("multiline-ternary"), Stylistic),
302-
UnsupportedRule(EslintVueJs("mustache-interpolation-spacing"), Stylistic),
302+
UnsupportedRule(
303+
EslintVueJs("mustache-interpolation-spacing"),
304+
FormatterCovers,
305+
),
303306
UnsupportedRule(
304307
EslintVueJs("new-line-between-multi-line-property"),
305308
Stylistic,

crates/biome_css_analyze/src/lint/nursery/use_baseline.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ declare_lint_rule! {
218218
name: "useBaseline",
219219
language: "css",
220220
recommended: false,
221-
sources: &[RuleSource::EslintCss("use-baseline").inspired()],
221+
sources: &[RuleSource::EslintCss("use-baseline").inspired(), RuleSource::HtmlEslint("use-baseline").inspired()],
222222
}
223223
}
224224

0 commit comments

Comments
 (0)