block face position fix + lint#2801
Merged
Merged
Conversation
Contributor
Author
|
Previous calculations for block faces were doing the distance to the corner of the block and then adding 0.5 instead of just doing the bots distance to the center of the block. That error caused the bot to think it was supposed to be looking at different sides of the block and skipping past open faces. |
WhoTho
added a commit
to WhoTho/mineflayer-pathfinder
that referenced
this pull request
Feb 1, 2023
Same thing as PrismarineJS/mineflayer#2801 The math for getting the position relative to the center of the block was off by a bit.
IceTank
pushed a commit
to PrismarineJS/mineflayer-pathfinder
that referenced
this pull request
Feb 2, 2023
Same thing as PrismarineJS/mineflayer#2801 The math for getting the position relative to the center of the block was off by a bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.