Allow more click modes (#3133)

* allow click modes higher than 0

* send null in item field with modes 2 / 4

* add comment

---------

Co-authored-by: Romain Beaumont <romain.rom1@gmail.com>

Author: kaduvert

lib/plugins/inventory.js

@@ -490,8 +490,7 @@ function inject (bot, { hideErrors }) {
     }
     const window = bot.currentWindow || bot.inventory
 
-    assert.ok(mouseButton === 0 || mouseButton === 1)
-    assert.strictEqual(mode, 0)
+    assert.ok(mode >= 0 && mode <= 4)
     const actionId = createActionNumber()
 
     const click = {
@@ -528,7 +527,8 @@ function inject (bot, { hideErrors }) {
         mouseButton,
         action: actionId,
         mode,
-        item: Item.toNotch(click.item)
+        // protocol expects null even if there is an item at the slot in mode 2 and 4
+        item: Item.toNotch((mode === 2 || mode === 4) ? null : click.item)
       })
     } else { // 1.17
       bot._client.write('window_click', {