Fix crash in digging plugin death handler (#3553) (#3835)

* Fix crash in digging plugin death handler when bot._events is undefined

When the bot dies during certain states (e.g. Velocity proxy transfers,
or when using Bun runtime), the EventEmitter internals can be torn down
before the death event fires. This causes removeAllListeners to throw
"TypeError: undefined is not an object (evaluating 'this._events')".

Wrapping the death handler in a try/catch prevents the crash.

Fixes #3553

Co-authored-by: Cursor <cursoragent@cursor.com>

* Add test for digging death handler crash fix

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Add external test for digging death crash fix

Verifies that killing the bot mid-dig via /kill doesn't crash, by
placing a block, starting to dig it in survival mode, killing the bot,
and confirming the death event fires and the bot respawns.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(test): reset state after diggingDeath to prevent cascading failures

After killing the bot, wait for chunks to load at the respawn point and
call resetState() so subsequent tests start with a clean creative-mode
bot at the origin with loaded chunks. Without this, the next test's
resetState() would fail with "Timeout waiting for chunks" or
"updateSlot did not fire" because the bot was still at the respawn
location without chunks.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Remove flaky diggingDeath external test (covered by unit test)

---------

Co-authored-by: Simeon Kummer <simeon@hitthecode.de>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: rom1504 <rom1504@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude <claude@anthropic.com>

Author: 5 people

lib/plugins/digging.js

@@ -210,9 +210,11 @@ function inject (bot) {
   }
 
   bot.on('death', () => {
-    bot.removeAllListeners('diggingAborted')
-    bot.removeAllListeners('diggingCompleted')
-    bot.stopDigging()
+    try {
+      bot.removeAllListeners('diggingAborted')
+      bot.removeAllListeners('diggingCompleted')
+      bot.stopDigging()
+    } catch (_) {}
   })
 
   function canDigBlock (block) {

test/diggingDeathTest.js

@@ -0,0 +1,90 @@
+/* eslint-env mocha */
+
+const EventEmitter = require('events')
+const assert = require('assert')
+const inject = require('../lib/plugins/digging')
+
+describe('digging plugin death handler', () => {
+  function createMockBot () {
+    const bot = new EventEmitter()
+    // The digging plugin assigns these on the bot
+    bot.targetDigBlock = null
+    bot.targetDigFace = null
+    bot.lastDigTime = null
+    // stopDigging is set by the plugin, but starts as the noop at bottom of digging.js
+    // We don't pre-set it so the plugin can assign it
+    // Provide minimal _client stub for stopDigging path (write is called during cancel)
+    bot._client = { write: () => {} }
+    // entity stub needed if canDigBlock or digTime are called
+    bot.entity = {
+      position: { x: 0, y: 0, z: 0, offset: () => ({ x: 0, y: 0, z: 0, distanceTo: () => 0 }) },
+      isInWater: false,
+      onGround: true,
+      eyeHeight: 1.62,
+      effects: {}
+    }
+    bot.heldItem = null
+    bot.game = { gameMode: 'survival' }
+    bot.inventory = { slots: [] }
+    bot.getEquipmentDestSlot = () => 5
+    bot.swingArm = () => {}
+    bot.world = { raycast: () => null }
+    return bot
+  }
+
+  it('should not throw when death is emitted and no digging is in progress', () => {
+    const bot = createMockBot()
+    inject(bot)
+    // Simply emitting death should not throw
+    assert.doesNotThrow(() => {
+      bot.emit('death')
+    })
+  })
+
+  it('should not throw when death is emitted and stopDigging throws', () => {
+    const bot = createMockBot()
+    inject(bot)
+    // Simulate a broken stopDigging that throws
+    bot.stopDigging = () => {
+      throw new Error('unexpected state error')
+    }
+    // The try/catch in the death handler should swallow this
+    assert.doesNotThrow(() => {
+      bot.emit('death')
+    })
+  })
+
+  it('should not throw when death is emitted with problematic event listeners', () => {
+    const bot = createMockBot()
+    inject(bot)
+    // Add a listener for diggingAborted that would be removed
+    bot.on('diggingAborted', () => {})
+    bot.on('diggingCompleted', () => {})
+    // Override removeAllListeners to throw (simulating the crash scenario)
+    const origRemoveAll = bot.removeAllListeners.bind(bot)
+    bot.removeAllListeners = (event) => {
+      if (event === 'diggingAborted') {
+        throw new Error('Cannot read properties of undefined')
+      }
+      return origRemoveAll(event)
+    }
+    // The try/catch should protect against this
+    assert.doesNotThrow(() => {
+      bot.emit('death')
+    })
+  })
+
+  it('should clean up digging listeners on death when digging is active', () => {
+    const bot = createMockBot()
+    inject(bot)
+    // Simulate active listeners
+    bot.on('diggingAborted', () => {})
+    bot.on('diggingCompleted', () => {})
+    assert.ok(bot.listenerCount('diggingAborted') > 0)
+    assert.ok(bot.listenerCount('diggingCompleted') > 0)
+    bot.emit('death')
+    // After death, digging listeners should be removed
+    assert.strictEqual(bot.listenerCount('diggingAborted'), 0)
+    assert.strictEqual(bot.listenerCount('diggingCompleted'), 0)
+  })
+})