Merge pull request #21381 from emberjs/nvp/fix-local-non-vscode-linting

NullVoxPopuli · web-flow · commit d8ee29d5334a · 2026-05-07T11:16:00.000-04:00
Update linting deps
diff --git a/package.json b/package.json
@@ -98,23 +98,24 @@
     "@tsconfig/ember": "3.0.8",
     "@types/qunit": "^2.19.4",
     "@types/rsvp": "^4.0.4",
+    "@typescript-eslint/typescript-estree": "^8.59.2",
     "ast-types": "^0.14.2",
     "auto-dist-tag": "^2.1.1",
     "babel-plugin-debug-macros": "1.0.0",
     "babel-plugin-ember-template-compilation": "^4.0.0",
     "dag-map": "^2.0.2",
-    "decorator-transforms": "2.0.0",
+    "decorator-transforms": "2.3.2",
     "ember-cli": "^6.11.1",
     "ember-cli-blueprint-test-helpers": "^0.19.2",
     "ember-cli-browserstack": "^2.0.1",
     "ember-cli-dependency-checker": "^3.3.1",
     "ember-cli-yuidoc": "^0.9.1",
     "eslint": "^9.21.0",
-    "eslint-import-resolver-node": "^0.3.7",
+    "eslint-import-resolver-node": "^0.3.10",
     "eslint-plugin-disable-features": "^0.1.3",
     "eslint-plugin-ember-internal": "^3.0.0",
     "eslint-plugin-import": "^2.31.0",
-    "eslint-plugin-n": "^17.16.2",
+    "eslint-plugin-n": "^18.0.1",
     "eslint-plugin-qunit": "^8.1.2",
     "execa": "^9.0.0",
     "expect-type": "^0.15.0",
@@ -138,7 +139,7 @@
     "testem-failure-only-reporter": "^1.0.0",
     "tracerbench": "^8.0.1",
     "typescript": "^5.7.3",
-    "typescript-eslint": "^8.26.0",
+    "typescript-eslint": "^8.59.2",
     "vite": "^7.0.0"
   },
   "resolutions": {
diff --git a/packages/@glimmer/compiler/lib/shared/list.ts b/packages/@glimmer/compiler/lib/shared/list.ts
@@ -20,7 +20,7 @@ export class PresentList<T> implements OptionalList<T> {
 
   map<U>(callback: (input: T) => U): MapList<T, U, PresentList<T>> {
     let result = mapPresentArray(this.list, callback);
-    return new PresentList(result) as MapList<T, U, this>;
+    return new PresentList(result);
   }
 
   filter<S extends T>(predicate: (value: T) => value is S): AnyOptionalList<S> {
@@ -48,7 +48,7 @@ export class EmptyList<T> implements OptionalList<T> {
   readonly list: T[] = [];
 
   map<U>(_callback: (input: T) => U): MapList<T, U, EmptyList<T>> {
-    return new EmptyList() as MapList<T, U, this>;
+    return new EmptyList();
   }
 
   filter<S extends T>(_predicate: (value: T) => value is S): AnyOptionalList<S> {
diff --git a/packages/@glimmer/compiler/lib/wire-format-debug.ts b/packages/@glimmer/compiler/lib/wire-format-debug.ts
@@ -172,7 +172,7 @@ export default class WireFormatDebugger {
           ];
 
         case Op.Concat:
-          return ['concat', this.formatParams(opcode[1] as WireFormat.Core.Params)];
+          return ['concat', this.formatParams(opcode[1])];
 
         case Op.GetStrictKeyword:
           return ['get-strict-free', this.upvars[opcode[1]]];
diff --git a/packages/@glimmer/debug-util/lib/present.ts b/packages/@glimmer/debug-util/lib/present.ts
@@ -55,13 +55,13 @@ export function asPresentArray<T>(list: T[], message = `unexpected empty list`):
 export function getLast<T>(list: PresentArray<T>): T;
 export function getLast<T>(list: T[]): T | undefined;
 export function getLast<T>(list: T[]): T | undefined {
-  return list.length === 0 ? undefined : (list[list.length - 1] as T);
+  return list.length === 0 ? undefined : list[list.length - 1];
 }
 
 export function getFirst<T>(list: PresentArray<T>): T;
 export function getFirst<T>(list: T[]): T | undefined;
 export function getFirst<T>(list: T[]): T | undefined {
-  return list.length === 0 ? undefined : (list[0] as T);
+  return list.length === 0 ? undefined : list[0];
 }
 
 export function mapPresentArray<T, U>(
diff --git a/packages/@glimmer/debug/lib/dism/operands.ts b/packages/@glimmer/debug/lib/dism/operands.ts
@@ -34,7 +34,7 @@ class Disassembler<in out Added extends OperandType> {
   static build(
     builder: (disassembler: Disassembler<never>) => Disassembler<AllOperands>
   ): Record<OperandType, OperandDisassembler> {
-    return builder(new Disassembler()).#disms as Record<OperandType, OperandDisassembler>;
+    return builder(new Disassembler()).#disms;
   }
 
   readonly #disms: Record<string, OperandDisassembler>;
diff --git a/packages/@glimmer/destroyable/index.ts b/packages/@glimmer/destroyable/index.ts
@@ -91,7 +91,7 @@ function getDestroyableMeta<T extends Destroyable>(destroyable: T): DestroyableM
     };
 
     if (DEBUG) {
-      meta.source = destroyable as object;
+      meta.source = destroyable;
     }
 
     DESTROYABLE_META.set(destroyable, meta);
diff --git a/packages/@glimmer/reference/lib/iterable.ts b/packages/@glimmer/reference/lib/iterable.ts
@@ -1,5 +1,5 @@
 import { DEBUG } from '@glimmer/env';
-import type { Dict, Nullable } from '@glimmer/interfaces';
+import type { Nullable } from '@glimmer/interfaces';
 import { getPath, toIterator } from '@glimmer/global-context';
 import { EMPTY_ARRAY } from '@glimmer/util/lib/array-utils';
 import { isIndexable } from '@glimmer/util/lib/collections';
@@ -58,7 +58,7 @@ function keyForPath(path: string): KeyFor {
     if (item === null || item === undefined) {
       return item;
     }
-    return getPath(item as object, path);
+    return getPath(item, path);
   });
 }
 
@@ -258,7 +258,7 @@ class ArrayIterator implements OpaqueIterator {
 
     let { keyFor } = this;
 
-    let key = keyFor(value as Dict, this.pos);
+    let key = keyFor(value, this.pos);
     let memo = this.pos;
 
     return { key, value, memo };
diff --git a/packages/@glimmer/runtime/lib/compiled/opcodes/content.ts b/packages/@glimmer/runtime/lib/compiled/opcodes/content.ts
@@ -34,12 +34,9 @@ import { AssertFilter } from './vm';
 function toContentType(value: unknown) {
   if (shouldCoerce(value)) {
     return ContentType.String;
-  } else if (
-    isCurriedType(value, CURRIED_COMPONENT) ||
-    hasInternalComponentManager(value as object)
-  ) {
+  } else if (isCurriedType(value, CURRIED_COMPONENT) || hasInternalComponentManager(value)) {
     return ContentType.Component;
-  } else if (isCurriedType(value, CURRIED_HELPER) || hasInternalHelperManager(value as object)) {
+  } else if (isCurriedType(value, CURRIED_HELPER) || hasInternalHelperManager(value)) {
     return ContentType.Helper;
   } else if (isSafeString(value)) {
     return ContentType.SafeString;
diff --git a/packages/@glimmer/runtime/lib/compiled/opcodes/vm.ts b/packages/@glimmer/runtime/lib/compiled/opcodes/vm.ts
@@ -86,7 +86,7 @@ APPEND_OPCODES.add(VM_PRIMITIVE_OP, (vm, { op1: primitive }) => {
   if (isHandle(primitive)) {
     // it is a handle which does not already exist on the stack
     let value = vm.constants.getValue(decodeHandle(primitive));
-    stack.push(value as object);
+    stack.push(value);
   } else {
     // is already an encoded immediate or primitive handle
     stack.push(decodeImmediate(primitive));
diff --git a/packages/@glimmer/runtime/lib/helpers/concat.ts b/packages/@glimmer/runtime/lib/helpers/concat.ts
@@ -5,7 +5,7 @@ import { reifyPositional } from '../vm/arguments';
 import { internalHelper } from './internal-helper';
 
 const isEmpty = (value: unknown): boolean => {
-  return value === null || value === undefined || typeof (value as object).toString !== 'function';
+  return value === null || value === undefined || typeof value.toString !== 'function';
 };
 
 const normalizeTextValue = (value: unknown): string => {
diff --git a/packages/@glimmer/runtime/lib/modifiers/on.ts b/packages/@glimmer/runtime/lib/modifiers/on.ts
@@ -176,7 +176,7 @@ export class OnModifierState {
     // https://bugs.chromium.org/p/chromium/issues/detail?id=770208
     if (shouldUpdate) {
       if (once !== undefined || passive !== undefined || capture !== undefined) {
-        options = { once, passive, capture } as AddEventListenerOptions;
+        options = { once, passive, capture };
       }
     }
 
diff --git a/packages/@glimmer/syntax/lib/parser/handlebars-node-visitors.ts b/packages/@glimmer/syntax/lib/parser/handlebars-node-visitors.ts
@@ -245,12 +245,7 @@ export abstract class HandlebarsNodeVisitors extends Parser {
         strip,
       });
     } else {
-      const { path, params, hash } = acceptCallNodes(
-        this,
-        rawMustache as HBS.MustacheStatement & {
-          path: HBS.PathExpression | HBS.SubExpression;
-        }
-      );
+      const { path, params, hash } = acceptCallNodes(this, rawMustache);
       mustache = b.mustache({
         path,
         params,
diff --git a/packages/@glimmer/syntax/lib/traversal/traverse.ts b/packages/@glimmer/syntax/lib/traversal/traverse.ts
@@ -25,7 +25,7 @@ function getEnterFunction<N extends ASTv1.Node, K extends VisitorKey<N>>(
   if (typeof handler === 'function') {
     return handler;
   } else {
-    return handler.enter as NodeHandler<N> | KeyHandler<N, K>;
+    return handler.enter;
   }
 }
 
@@ -41,7 +41,7 @@ function getExitFunction<N extends ASTv1.Node, K extends VisitorKey<N>>(
   if (typeof handler === 'function') {
     return undefined;
   } else {
-    return handler.exit as NodeHandler<N> | KeyHandler<N, K>;
+    return handler.exit;
   }
 }
 
diff --git a/packages/@glimmer/syntax/lib/v2/objects/resolution.ts b/packages/@glimmer/syntax/lib/v2/objects/resolution.ts
@@ -168,6 +168,6 @@ export function loadResolution(resolution: SerializedResolution): FreeVarResolut
   } else if (resolution === 'ComponentOrHelper') {
     return LooseModeResolution.append();
   } else {
-    return LooseModeResolution.namespaced(resolution as FreeVarNamespace);
+    return LooseModeResolution.namespaced(resolution);
   }
 }
diff --git a/packages/@glimmer/syntax/test/loc-node-test.ts b/packages/@glimmer/syntax/test/loc-node-test.ts
@@ -82,7 +82,7 @@ test('blocks', () => {
   locEqual(block, 2, 2, 9, 8, 'outer block');
   locEqual(nestedBlock, 3, 4, 7, 13, 'nested block');
   locEqual(nestedBlockText, 4, 0, 5, 0);
-  locEqual(nestedInverse as AST.Node, 5, 16, 7, 2);
+  locEqual(nestedInverse, 5, 16, 7, 2);
 });
 
 test('mustache', () => {
diff --git a/packages/@glimmer/util/lib/array-utils.ts b/packages/@glimmer/util/lib/array-utils.ts
@@ -1,4 +1,4 @@
-export const EMPTY_ARRAY: readonly unknown[] = Object.freeze([]) as readonly unknown[];
+export const EMPTY_ARRAY: readonly unknown[] = Object.freeze([]);
 
 export function emptyArray<T>(): T[] {
   return EMPTY_ARRAY as T[];
diff --git a/packages/@glimmer/validator/lib/collections/map.ts b/packages/@glimmer/validator/lib/collections/map.ts
@@ -50,7 +50,9 @@ export function trackedMap<Key = any, Value = any>(
           const hasExisting = target.has(key);
 
           if (hasExisting) {
-            const isUnchanged = equals(target.get(key) as Value, value);
+            // TS doesn't know about the relationship between has and get
+            // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+            const isUnchanged = equals(target.get(key)!, value);
 
             if (isUnchanged) return proxy;
           }
diff --git a/packages/@glimmer/validator/lib/collections/weak-map.ts b/packages/@glimmer/validator/lib/collections/weak-map.ts
@@ -47,7 +47,7 @@ export function trackedWeakMap<Key extends WeakKey, Value = unknown>(
           const hasExisting = target.has(key);
 
           if (hasExisting) {
-            const isUnchanged = equals(target.get(key) as Value, value);
+            const isUnchanged = equals(target.get(key), value);
 
             if (isUnchanged) return proxy;
           }
diff --git a/packages/@glimmer/validator/lib/utils.ts b/packages/@glimmer/validator/lib/utils.ts
@@ -10,5 +10,5 @@ export type Indexable = Record<AnyKey, unknown>;
 
 export function unwrap<T>(val: T | null | undefined): T {
   if (val === null || val === undefined) throw new Error(`Expected value to be present`);
-  return val as T;
+  return val;
 }
diff --git a/packages/@glimmer/validator/test/validators-test.ts b/packages/@glimmer/validator/test/validators-test.ts
@@ -114,7 +114,7 @@ module('@glimmer/validator: validators', () => {
       let snapshot = valueForTag(tag);
 
       // Now, we update the parent tag with the subtag, and revalidate it
-      updateTag(tag as unknown as UpdatableTag, subtag);
+      updateTag(tag, subtag);
 
       assert.ok(validateTag(tag, snapshot), 'tag is still valid after being updated');
 
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ export class PresentList<T> implements OptionalList<T> {`
`20`	`20`
`21`	`21`	`map<U>(callback: (input: T) => U): MapList<T, U, PresentList<T>> {`
`22`	`22`	`let result = mapPresentArray(this.list, callback);`
`23`		`- return new PresentList(result) as MapList<T, U, this>;`
	`23`	`+ return new PresentList(result);`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`filter<S extends T>(predicate: (value: T) => value is S): AnyOptionalList<S> {`
`@@ -48,7 +48,7 @@ export class EmptyList<T> implements OptionalList<T> {`
`48`	`48`	`readonly list: T[] = [];`
`49`	`49`
`50`	`50`	`map<U>(_callback: (input: T) => U): MapList<T, U, EmptyList<T>> {`
`51`		`- return new EmptyList() as MapList<T, U, this>;`
	`51`	`+ return new EmptyList();`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`filter<S extends T>(_predicate: (value: T) => value is S): AnyOptionalList<S> {`
Original file line number	Diff line number	Diff line change
@@ -55,13 +55,13 @@ export function asPresentArray<T>(list: T[], message = `unexpected empty list`):
`55`	`55`	`export function getLast<T>(list: PresentArray<T>): T;`
`56`	`56`	`export function getLast<T>(list: T[]): T \| undefined;`
`57`	`57`	`export function getLast<T>(list: T[]): T \| undefined {`
`58`		`- return list.length === 0 ? undefined : (list[list.length - 1] as T);`
	`58`	`+ return list.length === 0 ? undefined : list[list.length - 1];`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`export function getFirst<T>(list: PresentArray<T>): T;`
`62`	`62`	`export function getFirst<T>(list: T[]): T \| undefined;`
`63`	`63`	`export function getFirst<T>(list: T[]): T \| undefined {`
`64`		`- return list.length === 0 ? undefined : (list[0] as T);`
	`64`	`+ return list.length === 0 ? undefined : list[0];`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`export function mapPresentArray<T, U>(`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ class Disassembler<in out Added extends OperandType> {`
`34`	`34`	`static build(`
`35`	`35`	`builder: (disassembler: Disassembler<never>) => Disassembler<AllOperands>`
`36`	`36`	`): Record<OperandType, OperandDisassembler> {`
`37`		`- return builder(new Disassembler()).#disms as Record<OperandType, OperandDisassembler>;`
	`37`	`+ return builder(new Disassembler()).#disms;`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`readonly #disms: Record<string, OperandDisassembler>;`
Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ function getDestroyableMeta<T extends Destroyable>(destroyable: T): DestroyableM`
`91`	`91`	`};`
`92`	`92`
`93`	`93`	`if (DEBUG) {`
`94`		`- meta.source = destroyable as object;`
	`94`	`+ meta.source = destroyable;`
`95`	`95`	`}`
`96`	`96`
`97`	`97`	`DESTROYABLE_META.set(destroyable, meta);`